linux-kernel - Re: [PATCH] ftrace: Remove a superfluous check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333041834.23924.186.camel@gandalf.stny.rr.com>
Date:	Thu, 29 Mar 2012 13:23:54 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	Borislav Petkov <bp@...64.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: Remove a superfluous check

On Thu, 2012-03-29 at 19:17 +0200, John Kacur wrote:
> 

> It looks okay to me. Technically it's not functionally equivalent though, 
> because now when __register_ftrace_function is called directly, (in other 
> paths), the test has an unlikely there. See what Steven says, otherwise, 
> you can have my reviewed by.

Unlikely()s shouldn't affect things functionally, its just an
optimization hint.

Also, this check is unlikely to be true, so the hint is valid here.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/