linux-kernel - Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Mar 2012 16:02:33 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Matthew Garrett <mjg@...hat.com>, bhelgaas@...gle.com,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	stable@...r.kernel.org, Romain Francoise <romain@...bokech.com>,
	Chris Holland <bandidoirlandes@...il.com>,
	Colin Ian King <colin.king@...onical.com>,
	Hatem Masmoudi <hatem.masmoudi@...il.com>,
	janek <jan0x6c@...il.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children

Andrew Morton wrote:
> Jonathan Nieder <jrnieder@...il.com> wrote:

>> From: Matthew Garrett <mjg@...hat.com>
>> Date: Tue, 27 Mar 2012 10:17:41 -0400
[...]
>>            commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking
>> when ASPM is disabled") changed the behaviour of
>> pcie_aspm_sanity_check() to always return 0 if aspm is disabled, in
>> order to avoid cases where we changed ASPM state on pre-PCIe 1.1
>> devices.  This skipped the secondary function of
>> pcie_aspm_sanity_check which was to avoid us enabling ASPM on devices
>> that had non-PCIe children, causing trouble later on.
[...]
>>                                                               Could
>> you pick it up for linux-next until it makes its way to the PCI tree?
[...]
> Just about the only person who wasn't copied on this email is, umm, the
> PCI maintainer!

Well spotted.  Thanks for catching it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/