linux-kernel - Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Mar 2012 15:49:12 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Jonathan Nieder <jrnieder@...il.com>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	stable@...r.kernel.org, Romain Francoise <romain@...bokech.com>,
	Chris Holland <bandidoirlandes@...il.com>,
	Colin Ian King <colin.king@...onical.com>,
	Hatem Masmoudi <hatem.masmoudi@...il.com>,
	janek <jan0x6c@...il.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH resend] ASPM: Fix pcie devices with non-pcie children

On Thu, Mar 29, 2012 at 2:59 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Thu, 29 Mar 2012 21:56:35 +0100
> Matthew Garrett <mjg59@...f.ucam.org> wrote:
>
>> On Thu, Mar 29, 2012 at 01:46:14PM -0700, Andrew Morton wrote:
>>
>> > Just about the only person who wasn't copied on this email is, umm, the
>> > PCI maintainer!
>>
>> Jesse just handed that off to Bjorn…
>
> Oh.  So he did.   My search of MAINTAINERS turned up the probably wrong
>
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci.git

Yep, I'll update MAINTAINERS as soon as I set up a kernel.org tree.

The patch itself looks fine to me, so in case anybody wants to pick it
up earlier:

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

I do think that ASPM path is disappointingly hard to follow, which
likely contributed to the bug in the first place.
pcie_aspm_sanity_check() is a terrible name for something that returns
0/errno (which is treated as a bool meaning something like "do ASPM on
this device").  And the idea that we save this blacklist information
in the form of "link->aspm_enabled = ASPM_STATE_ALL" is weird.

But obviously, I'm ignorant of ASPM in general.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/