linux-kernel - Re: [PATCH v2] tty: hold lock across tty buffer finding and buffer filling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120330113407.7cbeaef6@pyramind.ukuu.org.uk>
Date:	Fri, 30 Mar 2012 11:34:07 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Tu, Xiaobing" <xiaobing.tu@...el.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Zhang, Yanmin" <yanmin.zhang@...el.com>,
	"Du, Alek" <alek.du@...el.com>, "Zuo, Jiao" <jiao.zuo@...el.com>
Subject: Re: [PATCH v2] tty: hold lock across tty buffer finding and buffer
 filling

On Fri, 30 Mar 2012 10:26:27 +0000
"Tu, Xiaobing" <xiaobing.tu@...el.com> wrote:

> Hi Greg
>   Even there still a prepare buffer not protected, the patch is still good to protect rest case, so this patch is still "nice to have"
> it makes the situation better. for the not-fixed case, we can have another patch to address that. Do you agree?

Can't speak for Greg (who I suspect is busy with the merge window to
Linus) but I think this is the right thing to do once the merge window is
over.  The unfixed case needs other things to happen first, such as the
removal of tty_lock/tty_unlock. At that point much of this should become
much simpler.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/