linux-kernel - Re: [PATCH] Fix USB Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120330124811.GA27330@x1.osrc.amd.com>
Date:	Fri, 30 Mar 2012 14:48:11 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Rupesh Gujare <rgujare@...odevices.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] Fix USB Kconfig

On Fri, Mar 30, 2012 at 12:05:32PM +0100, Rupesh Gujare wrote:
> Fix menuconfig option for USB. 
> 
> Signed-off-by: Rupesh Gujare <rgujare@...odevices.com>
> Reported-by: Borislav Petkov <bp@...en8.de>
> ---
>  drivers/usb/Kconfig |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index cbd8f5f..884f3fa 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -10,6 +10,13 @@ menuconfig USB_SUPPORT
>  	  This option adds core support for Universal Serial Bus (USB).
>  	  You will also need drivers from the following menu to make use of it.
>  
> +if USB_SUPPORT
> +
> +config USB_COMMON
> +	tristate
> +	default y
> +	depends on USB || USB_GADGET
> +
>  # many non-PCI SOC chips embed OHCI
>  config USB_ARCH_HAS_OHCI
>  	boolean
> @@ -63,13 +70,6 @@ config USB_ARCH_HAS_XHCI
>  	boolean
>  	default PCI
>  
> -if USB_SUPPORT
> -
> -config USB_COMMON
> -	tristate
> -	default y
> -	depends on USB || USB_GADGET
> -
>  # Host-side USB depends on having a host controller
>  # NOTE:  dummy_hcd is always an option, but it's ignored here ...
>  # NOTE:  SL-811 option should be board-specific ...

Reportedly, there's a fix for this already, see thread at
http://marc.info/?l=linux-usb&m=133310173203793&w=2

Thanks.

-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/