linux-kernel - Re: [PATCH 0/8 v7] fix gmbus writes and related issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333111775_156407@CP5-2952>
Date:	Fri, 30 Mar 2012 13:49:17 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Daniel Kurtz <djkurtz@...omium.org>,
	Keith Packard <keithp@...thp.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Daniel Vetter <daniel@...ll.ch>
Cc:	Benson Leung <bleung@...omium.org>,
	Yufeng Shen <miletus@...omium.org>,
	Daniel Kurtz <djkurtz@...omium.org>
Subject: Re: [PATCH 0/8 v7] fix gmbus writes and related issues

On Fri, 30 Mar 2012 19:46:35 +0800, Daniel Kurtz <djkurtz@...omium.org> wrote:
> This patchset addresses a couple of issues with the i915 gmbus
> implementation.
> 
> v7 adds a final patch to switch to using DRM_ERROR for reporting timeouts.
> 
> Daniel Kurtz (8):
>   drm/i915/intel_i2c: handle zero-length writes
>   drm/i915/intel_i2c: use double-buffered writes
>   drm/i915/intel_i2c: always wait for IDLE before clearing NAK
>   drm/i915/intel_i2c: use WAIT cycle, not STOP
>   drm/i915/intel_i2c: use INDEX cycles for i2c read transactions
>   drm/i915/intel_i2c: reuse GMBUS2 value read in polling loop
>   drm/i915/intel_i2c: remove POSTING_READ() from gmbus transfers
>   drm/i915/intel_i2c: use DRM_ERROR on timeouts

The only two I am still dubious about is 4/8: use WAIT cycle, not STOP,
and 8/8: use DRM_ERROR on timeouts, the rest are
Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

The last is a little debatable, as i2c can be called from userspace (and
other modules) and we have not verified that the adapters we set up
correspond to devices conditions. So I think it is still possible under
normal conditions to hit the error path, so would prefer to keep the log
level as INFO.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/