linux-kernel - Re: [PATCH 00/17] mark const init data with __initconst instead of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120330181936.GU15647@pengutronix.de>
Date:	Fri, 30 Mar 2012 20:19:36 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Andreas Schwab <schwab@...ux-m68k.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Anatolij Gustschin <agust@...x.de>,
	Andreas Koensgen <ajk@...nets.uni-bremen.de>,
	Andrew Lunn <andrew@...n.ch>,
	Andrew Victor <linux@...im.org.za>,
	Arnd Bergmann <arnd@...db.de>,
	Barry Song <baohua.song@....com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	cbe-oss-dev@...ts.ozlabs.org,
	Christoph Lameter <cl@...ux-foundation.org>,
	Daniel Walker <dwalker@...o99.com>,
	David Brown <davidb@...eaurora.org>,
	David Howells <dhowells@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	David Woodhouse <dwmw2@...radead.org>,
	davinci-linux-open-source@...ux.davincidsp.com,
	Eric Miao <eric.y.miao@...il.com>,
	Fenghua Yu <fenghua.yu@...el.com>, Grant@...l.home
Subject: Re: [PATCH 00/17] mark const init data with __initconst instead of
 __initdata

Hello Andreas,

On Fri, Mar 30, 2012 at 01:37:26PM +0200, Andreas Schwab wrote:
> Uwe Kleine-König <u.kleine-koenig@...gutronix.de> writes:
> 
> > After a question by Shawn Guo I noticed that my command to do the changes
> > was to lax and changed things that must not be changed (at least not
> > with further care). Affected are lines like:
> >
> > 	static const char *at91_dt_board_compat[] __initconst = {
> >
> > While at91_dt_board_compat[0] is const, at91_dt_board_compat is not.
> 
> Though it looks like at91_dt_board_compat should really be const (it is
> assigned to a const pointer, likewise for all other uses of struct
> machine_desc.dt_compat).
Yeah, still for this series I will revert to static const char
*at91_dt_board_compat[] __initdata to only have a single logical change.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/