linux-kernel - Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120330112650.2a36d833.akpm@linux-foundation.org>
Date:	Fri, 30 Mar 2012 11:26:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Geon Si Jeong <gshark.jeong@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

On Fri, 30 Mar 2012 15:38:28 +0900
Geon Si Jeong <gshark.jeong@...il.com> wrote:

> It is a simple driver for LM3556 Chip(Texas Instruments)
> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white LED.
> Datasheet: www.national.com/ds/LM/LM3556.pdf
> 
> Tested on OMAP4430
> 
> ...
>
> +EXPORT_SYMBOL_GPL(lm3556_read_reg);
> +EXPORT_SYMBOL_GPL(lm3556_write_reg);
> +EXPORT_SYMBOL_GPL(lm3556_write_bits);

These symbols are global and exported to modules, but have no
references outside this file.  Why?

> +static int lm3556_probe(struct i2c_client *client,
> +			const struct i2c_device_id *id)
> +{
> +	struct lm3556_platform_data *pdata = client->dev.platform_data;
> +	struct lm3556_chip_data *chip;
> +
> +	int err = -ENODEV;
> +
> +	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
> +		printk(KERN_ERR"[LM3556]i2c functionality check fail.\n");
> +		return err;
> +	}
> +
> +	if (pdata == NULL) {
> +		printk(KERN_ERR"[LM3556] Needs Platform Data.\n");
> +		return err;
> +	}
> +
> +	chip = kzalloc(sizeof(struct lm3556_chip_data), GFP_KERNEL);
> +	chip->client = client;
> +	chip->pdata = pdata;

tsk.

--- a/drivers/leds/leds-lm3556.c~leds-add-led-driver-for-lm3556-chip-fix
+++ a/drivers/leds/leds-lm3556.c
@@ -346,7 +346,6 @@ static int lm3556_probe(struct i2c_clien
 {
 	struct lm3556_platform_data *pdata = client->dev.platform_data;
 	struct lm3556_chip_data *chip;
-
 	int err = -ENODEV;
 
 	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
@@ -360,6 +359,8 @@ static int lm3556_probe(struct i2c_clien
 	}
 
 	chip = kzalloc(sizeof(struct lm3556_chip_data), GFP_KERNEL);
+	if (!chip)
+		return -ENOMEM;
 	chip->client = client;
 	chip->pdata = pdata;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/