lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Apr 2012 14:28:57 +0800 From: Lin Ming <ming.m.lin@...el.com> To: Aaron Lu <aaron.lu@....com> Cc: Len Brown <lenb@...nel.org>, "Rafeal J. Wysocki" <rjw@...k.pl>, linux-acpi@...r.kernel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>, Andiry Xu <andiry.xu@....com>, Alex He <alex.he@....com> Subject: Re: [PATCH] ACPI: evaluate _PS3 when entering D3 Cold On Sun, 2012-04-01 at 13:56 +0800, Aaron Lu wrote: > Hi, > > On Sun, Apr 01, 2012 at 01:27:33PM +0800, Lin Ming wrote: > > > - if (device->power.states[state].flags.explicit_set) { > > > + /* If state is D3 Cold, try to evaluate _PS3 first */ > > > + if (state == ACPI_STATE_D3_COLD) { > > > + explicit_set = (ps - 1)->flags.explicit_set; > > > + object_name[3] -= 1; > > > + } > > > > I'm not sure whether this works or not. > > > > From ACPI spec, > > > > _PS3 "is used to put the specific device into its D3hot or D3 state" > > > > D3 neither means D3hot nor D3cold. It's an old term before D3hot and > > D3cold were introduced. > I guess D3 has to mean something, right? :-) > > Here is the problem, there is no _PR3 in AMD's implementation, just _PS3. > And since _S0W evaluates 4, I've to put this device into D3 cold state > with _PS3. > > And the ACPI does have some words like: > > ------ > Platform/drivers must assume that the device will have power completely > removed when the device is place into “D3” via _PS3 > ------ > > This is in section 7.2.11: _PR3. > > > > > Another problem: > > > > With your patch, both D3hot and D3cold will evaluate _PS3, right? > > > Yes. > > > Will it have problem on AMD platform if you try to put ODD into D3hot > > state? _PS3 is evaluated, so it actually enters D3Cold state. > > There is no D3 hot support for this device(from the firmware's > perspective), either it is at D0(via _PS0), or it will be at D3 cold(via > _PS3). But this is the generic code. We can't only consider some special device. Maybe we need some flag to tell which D3 state _PS3 is used for. Lin Ming > > > Thanks for the review. > > -Aaron > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists