[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120401144125.GA2900@localhost.amd.com>
Date: Sun, 1 Apr 2012 22:41:25 +0800
From: Aaron Lu <aaron.lu@....com>
To: Lin Ming <ming.m.lin@...el.com>
CC: Len Brown <lenb@...nel.org>, "Rafeal J. Wysocki" <rjw@...k.pl>,
<linux-acpi@...r.kernel.org>, <linux-pm@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Zhang Rui <rui.zhang@...el.com>,
Andiry Xu <andiry.xu@....com>, Alex He <alex.he@....com>
Subject: Re: [PATCH] ACPI: evaluate _PS3 when entering D3 Cold
On Sun, Apr 01, 2012 at 02:28:57PM +0800, Lin Ming wrote:
> >
> > There is no D3 hot support for this device(from the firmware's
> > perspective), either it is at D0(via _PS0), or it will be at D3 cold(via
> > _PS3).
>
> But this is the generic code. We can't only consider some special
> device.
Agree.
The code change I've made only affects D3 cold path, existing code path
to set device power state to D0-D3hot is not affected.
And for D3 cold path, I don't think evaluating _PS3 should do any harm
to the device, isn't it the case?
>
> Maybe we need some flag to tell which D3 state _PS3 is used for.
Do you mean the ACPI spec needs to be updated to reflect which D3
state the device will be at once its _PS3 is evaluated?
-Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists