linux-kernel - Re: [PATCH 2/2] clkdev: Implement managed clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Apr 2012 18:21:33 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Mike Turquette <mturquette@...com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] clkdev: Implement managed clk_get()

On Mon, Apr 02, 2012 at 10:16:03AM -0700, Stephen Boyd wrote:
> On 04/02/12 10:08, Russell King - ARM Linux wrote:
> > Utter crap.  Deleting them makes the non-common clock implementations
> > unsafe.  If a struct clk is provided by a module (and we do have some
> > which are) then the module reference count has to be held.  That's
> > what these hooks do.
> >
> > When these platforms get converted over to the common clock, and the
> > issues surrounding dynamically registered and removed clocks are sane,
> > these hooks have to be used by the common clock to deal with the
> > refcounting so that common code knows when the structures can be freed.
> 
> I'm saying that when every platform is using the common clock code we
> would only have one __clk_get() implementation and we should be able to
> delete clkdev.h entirely.

No you did not, you said quite clearly that clkdev should go away and
be replaced by something else, because you see clkdev as just another
"platform specific implementation" (your words).  You were definitely
not talking about _just_ the backends for clkdev's clk_get().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/