linux-kernel - Re: CONFIG_RTLWIFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F79E5A5.9000004@lwfinger.net>
Date:	Mon, 02 Apr 2012 12:45:09 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Borislav Petkov <bp@...en8.de>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: CONFIG_RTLWIFI_DEBUG default y

On 04/02/2012 12:17 PM, Borislav Petkov wrote:
> On Mon, Apr 02, 2012 at 09:53:38AM -0700, Joe Perches wrote:
>> To keep all the "printk(KERN_DEBUG" to "pr_debug(" conversion
>> output the same as the it was prior to the patch.
>>
>> Larry can default it to off if he wants.
>
>> From looking at one user of this -
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c - some of the messages look
> like important ones which you wanna have enabled always, f.e. error
> handling in rtl92ce_hw_init().
>
> It probably needs splitting into debugging messages which are default n
> and always-on messages.

The current situation is fine with me. Any user with an embedded system can save 
a lot of memory by setting CONFIG_RTLWIFI_DEBUG to n. If a normal distro chooses 
to do that, then when some user of that distro reports a problem and is unable 
to run with the module parameter "debug=X", I get to say "Sorry, I cannot help 
you." :)

Of course, if you want to go through the source and convert every instance of 
"RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, ...)" to the equivalent "pr_err(...), 
then I would probably sign off on it.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/