linux-kernel - Re: CONFIG_RTLWIFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Apr 2012 10:29:28 -0700
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: CONFIG_RTLWIFI_DEBUG default y

On Mon, 2012-04-02 at 19:17 +0200, Borislav Petkov wrote:
> On Mon, Apr 02, 2012 at 09:53:38AM -0700, Joe Perches wrote:
> > To keep all the "printk(KERN_DEBUG" to "pr_debug(" conversion
> > output the same as the it was prior to the patch.
> > 
> > Larry can default it to off if he wants.
> 
> >From looking at one user of this -
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c - some of the messages look
> like important ones which you wanna have enabled always, f.e. error
> handling in rtl92ce_hw_init().
> 
> It probably needs splitting into debugging messages which are default n
> and always-on messages.

>From my perspective, anything KERN_DEBUG that should always be
output should not be KERN_DEBUG but some other KERN_<LEVEL>.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/