linux-kernel - RE: [PATCH RFC 2/4] regulator: Rework s5m8767_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <019601cd1126$971508e0$c53f1aa0$@com>
Date:	Tue, 03 Apr 2012 08:16:10 +0900
From:	Sangbeom Kim <sbkim73@...sung.com>
To:	'Axel Lin' <axel.lin@...il.com>, linux-kernel@...r.kernel.org
Cc:	'Liam Girdwood' <lrg@...com>,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Subject: RE: [PATCH RFC 2/4] regulator: Rework s5m8767_set_voltage to support
 both LDOs and BUCKs

On Sat, Mar 19, 2012 at 1:24 PM, Axel Lin wrote:
 
> s5m8767_set_voltage not only implement set_voltage callbacks for LDOs,
> but also for BUCKs when s5m8767->buck_gpioindex is not set.
> s5m8767_set_voltage_buck actually only for buck[2|3|4] when
> s5m8767->buck_gpioindex is set.
> Conditionally calling s5m8767_set_voltage in s5m8767_set_voltage_buck makes
> the code hard to read.
> 
> I think merging s5m8767_set_voltage_buck and s5m8767_set_voltage actually
> simplifies things. It's easy to use buck234_vol pointer to differentiate if
> we need to control voltage for buck[2|3|4] by DVS GPIOs.
> 
> This patch reworks s5m8767_set_voltage to support both LDOx and BUCKx in all
> cases.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
Hi, Axel
Basically, Your optimization code looks good.
But, S5M8767A support 9 Bucks. 
Please Add #9 Buck handling too.
As you know, 3.4-rc1 is released.
Please rebase your patch on 3.4-rc1.
Some feature is added on 3.4-rc1.

Thanks,
Sangbeom.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/