linux-kernel - Re: [PATCH] serial: 8250: Add cpufreq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403105530.7fa3bce7@pyramind.ukuu.org.uk>
Date:	Tue, 3 Apr 2012 10:55:30 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Shankarmurthy, Akshay" <akshay.s@...com>
Cc:	<linux-serial@...r.kernel.org>, <alan@...ux.intel.com>,
	<gregkh@...uxfoundation.org>, <paul.gortmaker@...driver.com>,
	<jamie@...ieiles.com>, <swarren@...dia.com>,
	<dianders@...omium.org>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	<linux-kernel@...r.kernel.org>, Chaithrika U S <chaithrika@...com>
Subject: Re: [PATCH] serial: 8250: Add cpufreq support

> This patch was submitted 2 years ago but didn't make it to the mainline. Now i am reposting it.

Can you fix it instead of just reposting it ?


> +#ifdef CONFIG_CPU_FREQ
> +static int serial8250_cpufreq_transition(struct notifier_block *nb,
> +					     unsigned long val, void *data)
> +{
> +	struct uart_8250_port *p;
> +	struct uart_port *uport;

What is your locking model ?


> +static inline void serial8250_cpufreq_deregister(struct uart_8250_port *p)

unregister

> +		ret = serial8250_cpufreq_register(uart);
> +		if (ret < 0)
> +			printk(KERN_ERR "Failed to add cpufreq notifier\n");

Why do this for devices that don't care.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/