[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.1204031125060.1537-100000@iolanthe.rowland.org>
Date: Tue, 3 Apr 2012 11:25:53 -0400 (EDT)
From: Alan Stern <stern@...land.harvard.edu>
To: Nicolas Ferre <nicolas.ferre@...el.com>
cc: plagnioj@...osoft.com, <linux-arm-kernel@...ts.infradead.org>,
<linux-usb@...r.kernel.org>, <ludovic.desroches@...el.com>,
<linux-kernel@...r.kernel.org>, <arnd@...db.de>, <olof@...om.net>
Subject: Re: [PATCH v2 06/13] USB: ohci-at91: change maximum number of ports
On Tue, 3 Apr 2012, Nicolas Ferre wrote:
> > Did you run this patch through scripts/checkpatch.pl? I have the
> > feeling that it might complain about some of the changes.
>
> Yes, definitively.
>
> I can modify the patch to comply with error issued by checkpatch.pl: several are
> due to a bad replacement of previous code with my regular expression but others
> where existing before my modifications.
> So what do you think about:
> - addressing all style errors in this patch (to prevent carrying them)
> - merging this one and the following patch:
> "[PATCH v2 07/13] USB: ohci-at91: coding style modifications with one-line ifs
> - posting a v3 of this patch only if you agree on this...
Sure, go ahead. Aside from this minor issue I didn't notice anything
objectionable in the patch series.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists