| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Apr 2012 17:46:10 -0400 (EDT) From: David Miller <davem@...emloft.net> To: cmetcalf@...era.com Cc: shemminger@...tta.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] marvell sky2 driver: fix so it works without unaligned accesses From: Chris Metcalf <cmetcalf@...era.com> Date: Tue, 3 Apr 2012 11:13:56 -0400 > The driver uses a receive_new() routine that ends up requiring unaligned > accesses in IP header processing. If the architecture doesn't support > efficient unaligned accesses, just copy all ingress packets to the bounce > buffers instead. > > This allows the driver to be used on the Tilera TILEmpower-Gx, since > the tile architecture doesn't currently handle kernel unaligned accesses, > just userspace. > > Signed-off-by: Chris Metcalf <cmetcalf@...era.com> As Stephen Hemminger alluded to, adjust the copybreak as needed. If you look at how other device drivers use this CONFIG variable, you'll get a better idea of what to do here if you want to adjust the default copybreak. Also keep in mind the issue brought up by Eric Dumazet in that not all kinds of sky2 chips would need this copybreak adjustment, only ones that have the SKY2_HW_RAM_BUFFER bit cleared. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists