linux-kernel - Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120403220946.GA6022@kroah.com>
Date:	Tue, 3 Apr 2012 15:09:46 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Geon Si Jeong <gshark.jeong@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

On Fri, Mar 30, 2012 at 03:38:28PM +0900, Geon Si Jeong wrote:
> It is a simple driver for LM3556 Chip(Texas Instruments)
> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white LED.
> Datasheet: www.national.com/ds/LM/LM3556.pdf
> 
> Tested on OMAP4430
> 
> Signed-off-by: Geon Si Jeong <gshark.jeong@...il.com>
> ---
>  drivers/leds/Kconfig        |    9 +
>  drivers/leds/Makefile       |    2 +-
>  drivers/leds/leds-lm3556.c  |  462 +++++++++++++++++++++++++++++++++++++++++++
>  include/linux/leds-lm3556.h |  242 ++++++++++++++++++++++

Why does this .h file have to be in include/linux/ ?

Why does it need to be a .h file at all?  Why can't it be part of the .c
file?

Only put files in include/linux/ that other files outside of your local
directory, need to access, and only put stuff in those files that other
files need to have.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/