linux-kernel - Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120406162835.d6fc1cac.akpm@linux-foundation.org>
Date:	Fri, 6 Apr 2012 16:28:35 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	shuahkhan@...il.com
Cc:	Geon Si Jeong <gshark.jeong@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Daniel Jeong <daniel.jeong@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] leds: Add LED driver for lm3556 chip

On Sat, 31 Mar 2012 21:37:23 -0600
Shuah Khan <shuahkhan@...il.com> wrote:

> > +	ret = kstrtoul(buf, 10, &state);
> > +	if (ret)
> > +		goto out;
> >  	if (isspace(*after))
> >  		count++;
> 
> after is used without initialization. Please note that simple_strtoul()
> initializes after. Don't think this will work.

I didn't try very hard ;)

I think I'll drop the whole patch.  According to my notes,

- Wolfram's comments should be addressed
- Move the header file out of include/linux/
- Consider using the regmap API
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/