linux-kernel - Re: some questions about __get_vm_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1204042308470.7534@chino.kir.corp.google.com>
Date:	Wed, 4 Apr 2012 23:09:39 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	vichy <vichy.kuo@...il.com>
cc:	Kautuk Consul <consul.kautuk@...il.com>,
	Kernel Newbies <kernelnewbies@...linux.org>,
	linux-kernel@...r.kernel.org
Subject: Re: some questions about __get_vm_area_node

On Thu, 5 Apr 2012, vichy wrote:

> Hi all:
> I have a question about __get_vm_area_node.
> Q. Why we announce "static struct vmap_area *va;" instead of "struct
> vmap_area *va;"
> I cannot see is there any benefit to take this variable as static.
> 

You're right, there's no need for it to be static.  However, you're 
looking at an old tree.

This was fixed with 0006526d78e9 ("mm/vmalloc.c: remove static declaration 
of va from __get_vm_area_node") in 3.3.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/