linux-kernel - Re: some questions about __get_vm_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Apr 2012 15:07:46 +0800
From:	vichy <vichy.kuo@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Kautuk Consul <consul.kautuk@...il.com>,
	Kernel Newbies <kernelnewbies@...linux.org>,
	linux-kernel@...r.kernel.org
Subject: Re: some questions about __get_vm_area_node

hi david:

2012/4/5 David Rientjes <rientjes@...gle.com>:
> On Thu, 5 Apr 2012, vichy wrote:
>
>> Hi all:
>> I have a question about __get_vm_area_node.
>> Q. Why we announce "static struct vmap_area *va;" instead of "struct
>> vmap_area *va;"
>> I cannot see is there any benefit to take this variable as static.
>>
>
> You're right, there's no need for it to be static.  However, you're
> looking at an old tree.
>
> This was fixed with 0006526d78e9 ("mm/vmalloc.c: remove static declaration
> of va from __get_vm_area_node") in 3.3.

Yes, I saw your check in message on Mon Dec 19 17:12:04 2011 -0800.
BTW, why we declare it as static previously?
for saving stack usage?
Thanks for your help,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/