linux-kernel - Re: some questions about __get_vm_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Apr 2012 00:20:03 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	vichy <vichy.kuo@...il.com>
cc:	Kautuk Consul <consul.kautuk@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: some questions about __get_vm_area_node

On Thu, 5 Apr 2012, vichy wrote:

> Yes, I saw your check in message on Mon Dec 19 17:12:04 2011 -0800.
> BTW, why we declare it as static previously?

Most likely copy-and-paste error by the original author.

> for saving stack usage?

For that you would need some kind of synchronization to protect it from 
concurrent access which doesn't exist in this context, so it was simply a 
mistake that got past review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/