linux-kernel - Re: [PATCHv3 1/3] misc: clean up bmp085 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120405063056.GA7135@skinner.xfiles.lan>
Date:	Thu, 5 Apr 2012 08:30:56 +0200
From:	Eric Andersson <eric.andersson@...xphere.com>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	alan@...rguk.ukuu.org.uk, arnd@...db.de,
	zhengguang.guo@...ch-sensortec.com, peter.moeller@...bosch.com,
	stefan.nilsson@...xphere.com, broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCHv3 1/3] misc: clean up bmp085 driver

Hi Joe,

On 12:55 Wed 04 Apr     , Joe Perches wrote:
> On Wed, 2012-04-04 at 21:45 +0200, Eric Andersson wrote:
> > This patch includes various cleaning of the bmp085 driver including:
> > - Whitespaces and alignment fixes
> > - Minor typos
> > - Consistency fixes
> 
> just some more trivial things:
> 
> > diff --git a/drivers/misc/bmp085.c b/drivers/misc/bmp085.c
> []
> > @@ -222,8 +217,10 @@ exit:
> >  /*
> >   * This function starts the pressure measurement and returns the value
> >   * in millibar. Since the pressure depends on the ambient temperature,
> > - * a temperature measurement is executed if the last known value is older
> > - * than one second.
> > + * a temperature measurement is executed according to the given temperature
> > + * measurememt period (default is 1 sec boundary). This period could vary
> 
> typo: measurement
> 
> > + * and needs to be adjusted according to the sensor environment, i.e. if big
> > + * temperature variations then the temperature needs to be read out often.
> 
> > @@ -386,25 +387,23 @@ static int bmp085_detect(struct i2c_client *client, struct i2c_board_info *info)
> >  
> >  static int bmp085_init_client(struct i2c_client *client)
> []
> > -	dev_info(&data->client->dev, "BMP085 ver. %d.%d found.\n",
> > -			(version & 0x0F), (version & 0xF0) >> 4);
> 
> Why remove the "version" output?

The version register is actually not an official register and is subject to
change in the future.

I'll fix the typos in next version!

Thanks!

-- 
Best regards,
 Eric

http://www.unixphere.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/