linux-kernel - Re: [PATCH v2] hugetlb: fix race condition in hugetlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1204061631160.3820@eggly.anvils>
Date:	Fri, 6 Apr 2012 16:35:29 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Chris Metcalf <cmetcalf@...era.com>,
	Hillf Danton <dhillf@...il.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault()

On Fri, 6 Apr 2012, Andrew Morton wrote:
> On Fri, 6 Apr 2012 16:10:13 -0700 (PDT)
> Hugh Dickins <hughd@...gle.com> wrote:
> > 
> > The resulting patch is okay; but let's reassure Chris that his
> > original patch was better, before he conceded to make the get_page
> > and put_page unconditional, and added unnecessary detail of the race.
> > 
> 
> Yes, the v1 patch was better.  No reason was given for changing it?

I think Chris was aiming to be a model citizen, and followed review
suggestions that he would actually have done better to resist.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/