[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120409174405.GA25990@kroah.com>
Date: Mon, 9 Apr 2012 10:44:05 -0700
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc: Alan Cox <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
linux-kernel@...r.kernel.org, qi.wang@...el.com,
yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH] pch_uart: Fix dma channel unallocated issue
On Tue, Mar 27, 2012 at 06:56:02PM +0900, Tomoya MORINAGA wrote:
> This driver anticipates pch_uart_verify_port() is not called
> during installation.
> However, actually pch_uart_verify_port() is called during
> installation.
> As a result, memory access violation occurs like below.
>
> 0. initial value: use_dma=0
> 1. starup()
> - dma channel is not allocated because use_dma=0
> 2. pch_uart_verify_port()
> - Set use_dma=1
> 3. UART processing acts DMA mode because use_dma=1
> - memory access violation occurs!
>
> This patch fixes the issue.
>
> Solution:
> Whenever pch_uart_verify_port() is called and then
> dma channel is not allocated, the channel should be allocated.
>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>
> ---
> drivers/tty/serial/pch_uart.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
This patch does not apply to 3.4-rc2, so I can not apply it, sorry.
Care to redo it?
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists