linux-kernel - Re: [PATCH] pch_uart: Fix dma channel unallocated issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQniAUT232kGLY0PmHi_kmXdFWKeX6289qCXkSw6N179yTg@mail.gmail.com>
Date:	Tue, 10 Apr 2012 10:26:25 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Alan Cox <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH] pch_uart: Fix dma channel unallocated issue

On Tue, Apr 10, 2012 at 2:44 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>> This driver anticipates pch_uart_verify_port() is not called
>> during installation.
>> However, actually pch_uart_verify_port() is called during
>> installation.
>> As a result, memory access violation occurs like below.
>>
>> 0. initial value: use_dma=0
>> 1. starup()
>>     - dma channel is not allocated because use_dma=0
>> 2. pch_uart_verify_port()
>>     - Set use_dma=1
>> 3. UART processing acts DMA mode because use_dma=1
>>      - memory access violation occurs!
>>
>> This patch fixes the issue.
>>
>> Solution:
>> Whenever pch_uart_verify_port() is called and then
>> dma channel is not allocated, the channel should be allocated.
>>
>> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>
>> ---
>>  drivers/tty/serial/pch_uart.c |    4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> This patch does not apply to 3.4-rc2, so I can not apply it, sorry.
>
> Care to redo it?

This patch depends on the following patch you've already accepted.

>From 44db113212d86a5870c2bfe8fb767fa842d68805 Mon Sep 17 00:00:00 2001
From: Tomoya MORINAGA <tomoya.rohm@...il.com>
Date: Mon, 26 Mar 2012 14:43:00 +0900
Subject: pch_uart: Delete unused structure member

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/tty/serial/pch_uart.c |    2 --
 1 file changed, 2 deletions(-)


So now,  this patch can be applied.
In fact, I've confirmed this patch can be applied to 3.4-rc2 with the
following order.
1st: pch_uart: Delete unused structure member
2nd: pch_uart: Fix dma channel unallocated issue

I should have written the dependency.
Could you try to apply this patch again ?

thanks
-- 
ROHM Co., Ltd.
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/