linux-kernel - Re: [PATCH 25/69] TTY: con3215, remove tasklet for tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120409182720.GA12044@kroah.com>
Date:	Mon, 9 Apr 2012 11:27:20 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux390@...ibm.com, linux-s390@...r.kernel.org
Subject: Re: [PATCH 25/69] TTY: con3215, remove tasklet for tty_wakeup

On Tue, Apr 03, 2012 at 09:59:19AM +0200, Jiri Slaby wrote:
> On 04/03/2012 07:42 AM, Heiko Carstens wrote:
> > On Mon, Apr 02, 2012 at 01:54:09PM +0200, Jiri Slaby wrote:
> >> tty_wakeup is safe to be called from all contexts. No need to schedule
> >> a tasklet for that. Let us call it directly like in other drivers.
> >>
> >> And delete the tasklet completely.
> > 
> > Your patch actually reverts Martin's recent commit 656d912537
> > "[S390] 3215 deadlock with tty_wakeup".
> > I'm quite sure the reason for the deadlock still exists.
> > Unfortunately the commit doesn't contain the call chain that
> > led to fix.
> 
> Ok, I would really appreciate the trace.
> 
> If this is really an issue, we should provide a helper in the TTY layer
> like tty_schedule_wakeup.

Jiri, should I not apply this patch?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/