lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Apr 2012 21:28:47 +0100 From: Chris Wilson <chris@...is-wilson.co.uk> To: Daniel Kurtz <djkurtz@...omium.org>, Daniel Kurtz <djkurtz@...omium.org>, Keith Packard <keithp@...thp.com>, David Airlie <airlied@...ux.ie>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Benson Leung <bleung@...omium.org>, Yufeng Shen <miletus@...omium.org> Subject: Re: [PATCH 4/8 v7] drm/i915/intel_i2c: use WAIT cycle, not STOP On Thu, 12 Apr 2012 02:16:45 +0800, Daniel Kurtz <djkurtz@...omium.org> wrote: > On Tue, Apr 10, 2012 at 11:03 PM, Daniel Vetter <daniel@...ll.ch> wrote: > > - Chris Wilson suggested on irc that we should wait for HW_READY even for > > zero-length writes (and also reads), currently we don't. > > I don't think so. We just need to wait for (GMBUS_SATOER | > GMBUS_HW_WAIT_PHASE). > Why would we wait for HW_READY, too? Just paranoia when looking at the read/write sequences and wondering how safe they were with 0-length read/writes. No real reason to suspect that the code is incorrect in any way. -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists