linux-kernel - Re: lib/raid6: SSSE3 optimized recovery functions v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120412161805.133c4ad0@notabene.brown>
Date:	Thu, 12 Apr 2012 16:18:05 +1000
From:	NeilBrown <neilb@...e.de>
To:	Jim Kukunas <james.t.kukunas@...ux.intel.com>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com
Subject: Re: lib/raid6: SSSE3 optimized recovery functions v2

On Wed, 11 Apr 2012 12:40:27 -0700 Jim Kukunas
<james.t.kukunas@...ux.intel.com> wrote:

> Hi Folks,
> 
> The following patchset adds SSSE3 optimized recovery
> functions to RAID6.
> 
> This version differs from version 1, in that:
>         0) cpu_has_ssse3 is moved to within the #ifdef block
> 	1) the functions are moved into their own file, recov_ssse3.c
> 	2) a superfluous memory load is removed from raid6_2data_recov_ssse3
> 
> A technical description of the algorithm can be found
> at http://www.kernel.org/pub/linux/kernel/people/hpa/raid6.pdf
> 
> Thanks.
> 


Thanks.

Could I trouble you to run 'checkpatch.pl' and fix up some of the more
reasonable complaints?

ERROR: open brace '{' following function declarations go on the next line
#243: FILE: lib/raid6/recov_ssse3.c:28:
+	static const u8 __attribute__((aligned(16))) x0f[16] = {

is clearly bogus, but 

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
#243: FILE: lib/raid6/recov_ssse3.c:28:
+	static const u8 __attribute__((aligned(16))) x0f[16] = {

is probably worth considering, as are some others.

NeilBrown


Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)