linux-kernel - Re: [ 00/78] 3.3.2-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120412144626.GA14868@kroah.com>
Date:	Thu, 12 Apr 2012 07:46:26 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Sergio Correia <lists@...e.net>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	linux-wireless Mailing List <linux-wireless@...r.kernel.org>,
	Sujith Manoharan <c_manoha@....qualcomm.com>,
	"ath9k-devel@...ts.ath9k.org" <ath9k-devel@...ema.h4ckr.net>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [ 00/78] 3.3.2-stable review

On Thu, Apr 12, 2012 at 04:32:40PM +0300, Felipe Contreras wrote:
> On Thu, Apr 12, 2012 at 4:13 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Thu, Apr 12, 2012 at 04:03:59AM +0300, Felipe Contreras wrote:
> >> On Thu, Apr 12, 2012 at 3:29 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> >> > On Wed, Apr 11, 2012 at 07:59:14PM -0400, Sergio Correia wrote:
> >> >> Hello Greg,
> >> >>
> >> >>
> >> >> On Wed, Apr 11, 2012 at 7:11 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> >> >> > This is the start of the stable review cycle for the 3.3.2 release.
> >> >> > There are 78 patches in this series, all will be posted as a response
> >> >> > to this one.  If anyone has any issues with these being applied, please
> >> >> > let me know.
> >> >> >
> >> >> > Responses should be made by Fri Apr 13 23:10:16 UTC 2012.
> >> >> > Anything received after that time might be too late.
> >> >> >
> >> >>
> >> >> is there any chance for this one to be included in this review cycle?
> >> >>
> >> >> http://www.spinics.net/lists/linux-wireless/msg87999.html
> >>
> >> I was going to ask for exactly the same thing. My system is completely
> >> unusable without this patch; not only does the network doesn't work,
> >> but quite often the kernel is stuck consuming 100% of the CPU.
> >>
> >> > Have you read Documentation/stable_kernel_rules.txt?  Based on that, I
> >> > don't think it can, yet, right?
> >>
> >> Why not? This patch makes the code go back to a previous state, it is
> >> obviously more stable than the current state, and the code already
> >> exists in Linus's tree (in previous releases).
> >
> > It does?  What is the git commit id of the patch?  Based in the email
> > above, I assumed it had not made it to Linus's tree already.
> 
> It's a revert of c1afdaff90538ef085b756454f12b29575411214, so so just
> take a look at the code in c1afdaff90538ef085b756454f12b29575411214^.
> 
> >> But hey, I guess it's OK that 3.3.x is stuck in and endless loop right
> >> after booting, because rules are more important than fixing obvious
> >> breakage.
> >
> > What rule did you think I was saying this was not acceptable for?
> 
> The fact that the patch as not been applied/reviewed/accepted upstream.
> 
> Personally I don't see what is the problem with reverts; we already
> know the previous code was working. Sure, in theory it might behave
> different due to other changes, but that doesn't seem to be the case
> here, plus, it can't be worst than the current situation of staying in
> an endless loop.

A revert is the same as a patch.  It needs to be in Linus's tree before
I can add it to the stable releases.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/