[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4F87186B.9010303@zytor.com>
Date: Thu, 12 Apr 2012 11:01:15 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Ingo Molnar <mingo@...e.hu>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Jesse Barnes <jbarnes@...tuousgeek.org>,
FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
x86@...nel.org, Giancarlo Asnaghi <giancarlo.asnaghi@...com>,
Alan Cox <alan@...ux.intel.com>,
Alessandro Rubini <rubini@...dd.com>
Subject: Re: [PATCH V4 1/3] x86: introduce CONFIG_X86_DEV_DMA_OPS
On 03/13/2012 11:56 PM, Ingo Molnar wrote:
>
> * Alessandro Rubini <rubini@...dd.com> wrote:
>
>> 32-bit x86 systems may need their own DMA operations, so add a
>> new config option, which is turned on for 64-bit systems. This
>> patch has no functional effect but it paves the way for
>> supporting the STA2x11 I/O Hub and possibly other chips.
>>
>> Signed-off-by: Alessandro Rubini <rubini@...dd.com>
>> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@...com>
>> Cc: Alan Cox <alan@...ux.intel.com>
>> ---
>> arch/x86/Kconfig | 5 +++++
>> arch/x86/include/asm/device.h | 4 ++--
>> arch/x86/include/asm/dma-mapping.h | 2 +-
>> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> Ok, the whole series looks pretty clean, modulo a few mostly
> cosmetic details in the driver itself.
>
> Andrew, you are typically merging dma-mapping.h patches, would
> you like to do these, or can we do it in tip:x86/platform?
>
> It would also be nice if the gents on Cc: would voice objections
> or approval, if any.
>
I looked over it, and at least this bit seems okay to me.
Acked-by: H. Peter Anvin <hpa@...or.com>
Andrew, I guess the question is still open?
I have to express some concern about where this device may be going, though.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists