linux-kernel - Re: [RESEND PATCH v2] libata: disable runtime pm for hotpluggable port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F871916.9080705@pobox.com>
Date:	Thu, 12 Apr 2012 14:04:06 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Lin Ming <ming.m.lin@...el.com>
CC:	linux-ide@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	jslaby@...e.cz, cwillu@...llu.com, jackdachef@...il.com,
	Sergei Shtylyov <sshtylyov@...sta.com>
Subject: Re: [RESEND PATCH v2] libata: disable runtime pm for hotpluggable
 port

On 04/12/2012 01:56 AM, Lin Ming wrote:
> Currently, hotplug doesn't work if port is already runtime suspended.
> For now, we simply disable runtime pm for hotpluggable port.
> Later, we should add runtime pm support for hotpluggable port too.
>
> Bug report:
> https://lkml.org/lkml/2012/2/19/70
>
> v2:
> - Use bit 2 and 3 for flags ATA_FLAG_EXTERNAL and ATA_FLAG_PLUGGABLE.
>
> TODO: add similar hotpluggable port check for controllers other than
> AHCI.
>
> Reported-and-tested-by: Jiri Slaby<jslaby@...e.cz>
> Reported-and-tested-by: cwillu@...llu.com
> Reported-and-tested-by: jackdachef@...il.com
> Signed-off-by: Lin Ming<ming.m.lin@...el.com>
> ---
>   drivers/ata/ahci.c             |    3 +++
>   drivers/ata/ahci.h             |    3 +++
>   drivers/ata/libahci.c          |   20 ++++++++++++++++++++
>   drivers/ata/libata-transport.c |    6 ++++--
>   include/linux/libata.h         |    2 ++
>   5 files changed, 32 insertions(+), 2 deletions(-)

The fundamental problem with this patch is that all SATA ports are 
hotpluggable... even the ones the firmware/silicon failed to mark as 
hotpluggable via AHCI's PORT_CMD_MPSP | PORT_CMD_HPCP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/