linux-kernel - Re: [PATCH] Fix modpost failures in fedora 17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120412.152325.787400025475295618.davem@davemloft.net>
Date:	Thu, 12 Apr 2012 15:23:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sam@...nborg.org
Cc:	mmarek@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix modpost failures in fedora 17

From: Sam Ravnborg <sam@...nborg.org>
Date: Thu, 12 Apr 2012 21:13:04 +0200

> On Thu, Apr 12, 2012 at 02:37:30PM -0400, David Miller wrote:
>> 
>> The symbol table on x86-64 starts to have entries that have names
>> like:
>> 
>> _GLOBAL__sub_I_65535_0___mod_x86cpu_device_table
>> 
>> They are of type STT_FUNCTION and this one had a length of 18.  This
>> matched the device ID validation logic and it barfed because the
>> length did not meet the device type's criteria.
>> 
>> --------------------
>> FATAL: arch/x86/crypto/aesni-intel: sizeof(struct x86cpu_device_id)=16 is not a modulo of the size of section __mod_x86cpu_device_table=18.
>> Fix definition of struct x86cpu_device_id in mod_devicetable.h
>> --------------------
>> 
>> These are some kind of compiler tool internal stuff being emitted and
>> not something we want to inspect in modpost's device ID table
>> validation code.
>> 
>> So skip the symbol if it is not of type STT_OBJECT.
>> 
>> Signed-off-by: David S. Miller <davem@...emloft.net>
> Acked-by: Sam Ravnborg <sam@...nborg.org>
> 
> I assume this is stable material too?

Yes.

> In other words we should add:
> Cc: stable@...r.kernel.org

Indeed, we should.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/