linux-kernel - Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120413080927.72cca80f@tlielax.poochiereds.net>
Date:	Fri, 13 Apr 2012 08:09:27 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Jim Rees <rees@...ch.edu>
Cc:	linux-fsdevel@...r.kernel.org, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, pstaubach@...grid.com,
	miklos@...redi.hu, viro@...IV.linux.org.uk, hch@...radead.org,
	michael.brantley@...haw.com
Subject: Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from
 getattr call

On Fri, 13 Apr 2012 08:02:32 -0400
Jim Rees <rees@...ch.edu> wrote:

> Jeff Layton wrote:
> 
>   +retry:
>    	error = user_path_at(dfd, filename, lookup_flags, &path);
>    	if (error)
>    		goto out;
>    
>    	error = vfs_getattr(path.mnt, path.dentry, stat);
>   +	should_retry = error == -ESTALE ? retry_estale(path.dentry) : false;
>    	path_put(&path);
>   +	if (should_retry) {
>   +		lookup_flags |= LOOKUP_REVAL;
>   +		goto retry;
>   +	}
>    out:
>    	return error;
>    }
> 
> This is starting to look like FORTRAN.  Maybe turn this into a "do while"?
> Then you could make the "goto out" into a break and get rid of them both.

Sure, that's doable. If we want to do a finite number of retries that
may be preferable anyway.

-- 
Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/