linux-kernel - Re: [RFC] workqueue: do a sanity check on new work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YOSy-acB7Oara9ay1Zeznx0vCSB0Z23F+6KtEKZ56nXmQ@mail.gmail.com>
Date:	Fri, 13 Apr 2012 09:39:13 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Matt Renzelmann <mjr@...wisc.edu>
Subject: Re: [RFC] workqueue: do a sanity check on new work

Hello, Dan.

On Fri, Apr 13, 2012 at 7:35 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> There may be a better way to do this.  If someone tries to call
> shedule_work() on a work_struck before doing an INIT_WORK() then we
> hit the BUG_ON(!list_empty(&work->entry)) in __queue_work() and hang.
> Instead of that, we could just print a stack dump and return.

Hmmm... why not just change the BUG_ON() in __queue_work() to "if
(WARN_ON()) return;"?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/