lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Apr 2012 10:12:21 -0400 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: Laxman Dewangan <ldewangan@...dia.com> CC: "sameo@...ux.intel.com" <sameo@...ux.intel.com>, "broonie@...nsource.wolfsonmicro.com" <broonie@...nsource.wolfsonmicro.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-next@...r.kernel.org" <linux-next@...r.kernel.org> Subject: Re: [PATCH] mfd: fix modular builds of rc5t583 regulator support On 12-04-16 02:54 AM, Laxman Dewangan wrote: > On Monday 16 April 2012 09:38 AM, Paul Gortmaker wrote: >> The combination of commit 1b1247dd75aa5cf5fae54a3bec7280046e9c7957 >> >> "mfd: Add support for RICOH PMIC RC5T583" >> >> and commit 6ffc3270210efa2bea526953a142ffc908f5bd86 >> >> "regulator: Add support for RICOH PMIC RC5T583 regulator" >> >> are causing the i386 allmodconfig builds to fail with this: >> >> ERROR: "rc5t583_update" [drivers/regulator/rc5t583-regulator.ko] undefined! >> ERROR: "rc5t583_set_bits" [drivers/regulator/rc5t583-regulator.ko] undefined! >> ERROR: "rc5t583_clear_bits" [drivers/regulator/rc5t583-regulator.ko] undefined! >> ERROR: "rc5t583_read" [drivers/regulator/rc5t583-regulator.ko] undefined! >> >> and this: >> >> ERROR: "rc5t583_ext_power_req_config" [drivers/regulator/rc5t583-regulator.ko] undefined! >> >> For the 1st four, make the simple ops static inline, instead of >> polluting the namespace with trivial exports. For the last one, >> add an EXPORT_SYMBOL. >> >> Signed-off-by: Paul Gortmaker<paul.gortmaker@...driver.com> >> --- >> >> [ alternately, make REGULATOR_RC5T583 bool instead of tristate? ] > > Why not export all require symbol from mfd core. > I am sending the patch to exporting all required apis. Please review. As I said in the commit log, it doesn't seem to make sense to export them when they are trivial enough to be static inline, since it avoids having them pollute the /proc/kallsyms namespace. It is almost like having basic inb/outb as functions vs inline; it just doesn't make sense to me. However, if you are determined to rewrite the patch in another way, please add the customary reported-by line. Thanks, Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists