linux-kernel - Re: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1204161106410.1408-100000@iolanthe.rowland.org>
Date:	Mon, 16 Apr 2012 11:09:25 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Roland Stigge <stigge@...com.de>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kevin.wells@....com>,
	<srinivas.bakki@....com>, <arnd@...db.de>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/3] USB: Add driver for NXP ISP1301 USB transceiver

On Mon, 16 Apr 2012, Roland Stigge wrote:

> This very-lowlevel driver registers the NXP ISP1301 chip via the I2C subsystem.
> The chip is the USB transceiver shared by ohci-nxp, lpc32xx_udc (gadget) and
> isp1301_omap.
> 
> Following patches let the respective USB host and gadget drivers use this
> driver, instead of duplicating ISP1301 handling.
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>
> 
> ---
> 
> Applies to v3.4-rc3
> 
> This driver needs to be probe()d before the respective USB driver using it. For
> modules, this is handled via the module dependency. When linking statically, it
> is done via linking order in the Makefile (misc/ before host/ and the gadget/).
> 
> Currently, only one ISP1301 chip is supported. To support multiple instances,
> we would need a mechanism to identify the respective chips via DT (and static
> resources or platform data) to be referenced by the higher level USB driver at
> isp1301_get_client(). Any suggestions?
> 
> 
>  drivers/usb/Makefile        |    5 ++
>  drivers/usb/misc/Kconfig    |   12 ++++++
>  drivers/usb/misc/Makefile   |    1 
>  drivers/usb/misc/isp1301.c  |   64 ++++++++++++++++++++++++++++++++++
>  include/linux/usb/isp1301.h |   82 ++++++++++++++++++++++++++++++++++++++++++++

You know, drivers/usb/misc is meant for miscellaneous USB device 
drivers.  Not for host or transceiver drivers.

You should put the new file somewhere else.  Maybe in the otg 
directory, although that may not be completely appropriate either.  
Maybe something under the host directory.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/