linux-kernel - Re: [PATCH v2] mfd: asic3: Avoid unbalanced irq wakeup enables/disables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120416164014.GO24130@sortiz-mobl>
Date:	Mon, 16 Apr 2012 18:40:14 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Paul Parsons <lost.distance@...oo.com>
Cc:	linux-kernel@...r.kernel.org, philipp.zabel@...il.com
Subject: Re: [PATCH v2] mfd: asic3: Avoid unbalanced irq wakeup
 enables/disables

Hi Paul,

On Wed, Apr 11, 2012 at 12:35:34AM +0100, Paul Parsons wrote:
> The mfd/asic3 driver does not currently define a irq_set_wake() handler.
> Consequently any attempt to configure the 3 ASIC3 GPIO buttons - RECORD,
> CALENDAR, HOME - as wakeup sources results in Unbalanced IRQ warnings
> when the system is woken from sleep mode:
> 
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 342 wake disable
> ...
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 337 wake disable
> ...
> WARNING: at kernel/irq/manage.c:520 irq_set_irq_wake+0xc4/0xf8()
> Unbalanced IRQ 339 wake disable
> ...
> 
> This patch adds a irq_set_wake() handler to the mfd/asic3 driver.
> 
> Signed-off-by: Paul Parsons <lost.distance@...oo.com>
> Cc: Philipp Zabel <philipp.zabel@...il.com>
> ---
> 
> V2:
> This patch now adds asic3_gpio_irq_set_wake() to mfd/asic3 instead of
> disabling the 3 ASIC3 GPIO buttons as wakeup sources in pxa/hx4700.
> This patch now submitted to linux-kernel instead of linux-arm-kernel.
> Rebased from linux-2.6.39-rc6 to linux-3.4-rc2.
Thanks, patch applied as well.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/