linux-kernel - Re: [PATCH v4 2/2] regulator: add device tree support for max8997

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Apr 2012 19:38:29 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Thomas Abraham <thomas.abraham@...aro.org>
Cc:	Karol Lewandowski <k.lewandowsk@...sung.com>,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	rob.herring@...xeda.com, grant.likely@...retlab.ca,
	kgene.kim@...sung.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, patches@...aro.org,
	Rajendra Nayak <rnayak@...com>
Subject: Re: [PATCH v4 2/2] regulator: add device tree support for max8997

On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@...sung.com> wrote:

> >> +    For BUCK's:

No 's here, BTW.

> >  - EN32KHz_AP
> >  - EN32KHz_CP
> >  - ENVICHG
> >  - ESAFEOUT1
> >  - ESAFEOUT2
> >  - CHARGER
> >  - CHARGER_CV
> >  - CHARGER_TOPOFF

> > I wonder if these should be mentioned in documentation too.

> Yes, I missed the above regulators in the documentation. I have
> included them now and will resubmit this patch.

Please omit the clocks; these are obviously a bodge due to the inability
to support clocks off-SoC so we shouldn't be enshrining them in the
device tree bindings.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)