linux-kernel - Re: [PATCH v4 2/2] regulator: add device tree support for max8997

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJuYYwSg-VkWe=0PFNj2snX4+_fN7Lc1-YU1xdUvTM9uJvha7A@mail.gmail.com>
Date:	Wed, 18 Apr 2012 13:46:58 +0530
From:	Thomas Abraham <thomas.abraham@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Karol Lewandowski <k.lewandowsk@...sung.com>,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	rob.herring@...xeda.com, grant.likely@...retlab.ca,
	kgene.kim@...sung.com, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, patches@...aro.org,
	Rajendra Nayak <rnayak@...com>
Subject: Re: [PATCH v4 2/2] regulator: add device tree support for max8997

Hi Mark,

On 18 April 2012 00:08, Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:
> On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
>> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@...sung.com> wrote:
>
>> >> +    For BUCK's:
>
> No 's here, BTW.

Ok.

>
>> >  - EN32KHz_AP
>> >  - EN32KHz_CP
>> >  - ENVICHG
>> >  - ESAFEOUT1
>> >  - ESAFEOUT2
>> >  - CHARGER
>> >  - CHARGER_CV
>> >  - CHARGER_TOPOFF
>
>> > I wonder if these should be mentioned in documentation too.
>
>> Yes, I missed the above regulators in the documentation. I have
>> included them now and will resubmit this patch.
>
> Please omit the clocks; these are obviously a bodge due to the inability
> to support clocks off-SoC so we shouldn't be enshrining them in the
> device tree bindings.

Thanks for the suggestion. I have removed EN32KHz_AP and EN32KHz_CP
from the list. The rest are either voltage (fixed) or current
regulators.

Regards,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/