linux-kernel - Re: [PATCH linux-next] mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1204171324500.10932@chino.kir.corp.google.com>
Date:	Tue, 17 Apr 2012 13:25:45 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH linux-next] mm/hugetlb: fix warning in
 alloc_huge_page/dequeue_huge_page_vma

On Tue, 17 Apr 2012, Konstantin Khlebnikov wrote:

> This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877
> ("cpuset: mm: reduce large amounts of memory barrier related damage v3")
> 
> Local variable "page" can be uninitialized if nodemask from vma policy does not
> intersects with nodemask from cpuset. Even if it wouldn't happens it's better to
> initialize this variable explicitly than to introduce kernel oops on weird corner case.
> 
> mm/hugetlb.c: In function ‘alloc_huge_page’:
> mm/hugetlb.c:1135:5: warning: ‘page’ may be used uninitialized in this function
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> Cc: Mel Gorman <mgorman@...e.de>

Acked-by: David Rientjes <rientjes@...gle.com>

This isn't just in -next, it's also in Linus' tree and seems like 3.4-rc4 
material to me.