linux-kernel - Re: [PATCH v2] i2c: tegra: Add delay before reset the controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120418142758.GE19220@pengutronix.de>
Date:	Wed, 18 Apr 2012 16:27:58 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Alok Chauhan <alokc@...dia.com>
Cc:	swarren@...dotorg.org, khali@...ux-fr.org, ben-linux@...ff.org,
	swarren@...dia.com, olof@...om.net, bones@...retlab.ca,
	omaplinuxkernel@...il.com, ccross@...roid.com,
	ldewangan@...dia.com, linux-tegra@...r.kernel.org,
	linux-i2c@...r.kernel.org, dgreid@...omium.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: tegra: Add delay before reset the controller

On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote:
> NACK interrupt generated before I2C controller generates
> the STOP condition on bus. In Software, because of this
> reset of controller is happening before I2C controller could
> complete STOP condition. So wait for some time before resetting
> the controller so that STOP condition has delivered properly on bus.
> 
> Added delay of 2 clock period before reset the
> controller in case of NACK error.
> 
> Signed-off-by: Alok Chauhan <alokc@...dia.com>

Applied with Stephen's ACK and slightly reworded comment and commit msg.

Wondering a bit that you want it for 3.5, not for 3.4. Looks like a
bugfix to me.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)