linux-kernel - Re: [PATCH v2] i2c: tegra: Add delay before reset the controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8F1DBD.8000009@wwwdotorg.org>
Date:	Wed, 18 Apr 2012 14:02:05 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	Alok Chauhan <alokc@...dia.com>, khali@...ux-fr.org,
	ben-linux@...ff.org, swarren@...dia.com, olof@...om.net,
	bones@...retlab.ca, omaplinuxkernel@...il.com, ccross@...roid.com,
	ldewangan@...dia.com, linux-tegra@...r.kernel.org,
	linux-i2c@...r.kernel.org, dgreid@...omium.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: tegra: Add delay before reset the controller

On 04/18/2012 08:27 AM, Wolfram Sang wrote:
> On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote:
>> NACK interrupt generated before I2C controller generates
>> the STOP condition on bus. In Software, because of this
>> reset of controller is happening before I2C controller could
>> complete STOP condition. So wait for some time before resetting
>> the controller so that STOP condition has delivered properly on bus.
>>
>> Added delay of 2 clock period before reset the
>> controller in case of NACK error.
>>
>> Signed-off-by: Alok Chauhan <alokc@...dia.com>
> 
> Applied with Stephen's ACK and slightly reworded comment and commit msg.
> 
> Wondering a bit that you want it for 3.5, not for 3.4. Looks like a
> bugfix to me.

Yes, applying this to 3.4 would make sense. When I said "for 3.5"
earlier, I meant I'd like it to at least get into 3.5 not later.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/