linux-kernel - Re: [PATCH] HID: hid-input: default HID_BATTERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1204181926340.16373@pobox.suse.cz>
Date:	Wed, 18 Apr 2012 19:28:42 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	Josh Boyer <jwboyer@...hat.com>,
	Bastien Nocera <hadess@...ess.net>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-team@...oraproject.org, Richard Hughes <richard@...hsie.com>
Subject: Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

On Wed, 18 Apr 2012, Matthew Garrett wrote:

> > Matthew suggested that additional kernel patches were required to add a
> > scope parameter so upower could understand that the battery is powering
> > a device and not the system.
> > 
> > Also, when did it become OK to force-enable a new feature that is
> > _known_ to not work properly on recent userspace?  That makes no sense
> > to me.
> 
> I agree. It's a great feature, but it shouldn't be default y if 
> userspace isn't ready for it yet.

Fully agreed, the 'default y' part escaped my attention. I will be 
applying the patch and pushing out to Linus.

I even wonder whether we shouldn't put a warning into the Kconfig entry, 
explaining the consequences of having userspace not ready for the feature.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/