linux-kernel - Re: [PATCH] HID: hid-input: default HID_BATTERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWEZMWrbQrf_q9fCDj4rfxuhdqW=o9857+VseJDJ-ogyA@mail.gmail.com>
Date:	Sun, 22 Apr 2012 10:38:57 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Matthew Garrett <mjg@...hat.com>, Josh Boyer <jwboyer@...hat.com>,
	Bastien Nocera <hadess@...ess.net>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-team@...oraproject.org, Richard Hughes <richard@...hsie.com>
Subject: Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

On Wed, Apr 18, 2012 at 19:28, Jiri Kosina <jkosina@...e.cz> wrote:
> On Wed, 18 Apr 2012, Matthew Garrett wrote:
>> > Matthew suggested that additional kernel patches were required to add a
>> > scope parameter so upower could understand that the battery is powering
>> > a device and not the system.
>> >
>> > Also, when did it become OK to force-enable a new feature that is
>> > _known_ to not work properly on recent userspace?  That makes no sense
>> > to me.
>>
>> I agree. It's a great feature, but it shouldn't be default y if
>> userspace isn't ready for it yet.
>
> Fully agreed, the 'default y' part escaped my attention. I will be
> applying the patch and pushing out to Linus.
>
> I even wonder whether we shouldn't put a warning into the Kconfig entry,
> explaining the consequences of having userspace not ready for the feature.

I saw it move from HID_BATTERY_STRENGTH=y to "# HID_BATTERY_STRENGTH
is not set" in my max-all build.

As there's no help entry, and no other option selects it, HID_BATTERY_STRENGTH
cannot be set anyway in v3.4-rc4?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/