linux-kernel - Re: [PATCH] xtensa: fix build failure in xtensa/kernel/signal.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334821525.26997.39.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Thu, 19 Apr 2012 08:45:25 +0100
From:	Matt Fleming <matt.fleming@...el.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Chris Zankel <chris@...kel.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] xtensa: fix build failure in xtensa/kernel/signal.c

On Wed, 2012-04-18 at 16:50 -0400, Paul Gortmaker wrote:
> Caused by commit 3785006ac3c8941feb63097c416de92114a6bc39
> 
>     "xtensa: don't mask signals if we fail to setup signal stack"
> 
> It assigns a return value to "ret", but there is no such variable
> anywhere in scope.  Create one.
> 
> Cc: Matt Fleming <matt.fleming@...el.com>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Chris Zankel <chris@...kel.net>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> diff --git a/arch/xtensa/kernel/signal.c b/arch/xtensa/kernel/signal.c
> index b69b000..d78869a 100644
> --- a/arch/xtensa/kernel/signal.c
> +++ b/arch/xtensa/kernel/signal.c
> @@ -496,6 +496,7 @@ int do_signal(struct pt_regs *regs, sigset_t *oldset)
>  	signr = get_signal_to_deliver(&info, &ka, regs, NULL);
>  
>  	if (signr > 0) {
> +		int ret;
>  
>  		/* Are we from a system call? */
>  

Whoops! Thanks Paul, that's my bad. Looks like I went code-blind after
making the same kinds of changes to lots of different architectures.

I've added Andrew to the Cc list since he picked up the last set of
xtensa signal patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/