linux-kernel - RE: [PATCH] smb347_charger: Cleanup power supply registration code in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D854C92F57B1B347B57E531E78D05EAD10E559@BGSMSX102.gar.corp.intel.com>
Date:	Thu, 19 Apr 2012 11:30:43 +0000
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	Mika Westerberg <mika.westerberg@....fi>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Anton Vorontsov <anton.vorontsov@...aro.org>
Subject: RE: [PATCH] smb347_charger: Cleanup power supply registration code
 in probe

> >>
> >> On Fri, Apr 13, 2012 at 03:14:52PM +0530, Ramakrishna Pallala wrote:
> >> > This patch checks if the usb or mains charging is enabled by the
> >> > platform before registering with the power supply class.
> >>
> >> Can you describe why this change is needed? The current code always
> >> registers all the power-supplies but if we haven't enabled for
> >> example USB charging, then the online property for USB ps is set to 0.
> >
> > If we haven't enabled USB charging then why to waste kernel resources?
> > What we will gain by registering with power supply class if USB charging is not
> enabled?
> 
> For one we have a consistent interface to userspace regardless of how the platform has
> configured the driver. For example if USB charging is not enabled userspace can still
> see the 'smb347-usb' directory but 'online' attribute is always set to zero.

what is gain and why user space need to see for usb online property and get disappointed when
platform has disabled USB charging( where user/user space has no idea about this).

if usb charging is  not enabled just don't register. I think it's clean and make more sense to me.

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/