| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CALp=xyOhHSY-fSQfm8S30JgosjFqMFm4pj0o23s-A6JSPfzQKw@mail.gmail.com> Date: Thu, 19 Apr 2012 15:03:51 +0300 From: Mika Westerberg <mika.westerberg@....fi> To: "Pallala, Ramakrishna" <ramakrishna.pallala@...el.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Anton Vorontsov <cbouatmailru@...il.com>, Anton Vorontsov <anton.vorontsov@...aro.org> Subject: Re: [PATCH] smb347_charger: Cleanup power supply registration code in probe On Thu, Apr 19, 2012 at 2:30 PM, Pallala, Ramakrishna <ramakrishna.pallala@...el.com> wrote: > > what is gain and why user space need to see for usb online property and get disappointed when > platform has disabled USB charging( where user/user space has no idea about this). Userspace doesn't have to know anything about how the platform is configured. It just reads standard and documented attributes and reacts on those. > if usb charging is not enabled just don't register. I think it's clean and make more sense to me. I disagree but I'll let Anton to decide which is better and how it is supposed to work. Btw, I think you should also check those places where power_supply_changed() is called for the supplies and make those conditional to what is registered. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists