linux-kernel - Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Apr 2012 15:36:57 +0400
From:	Stanislav Kinsbursky <skinsbursky@...allels.com>
To:	"Trond.Myklebust@...app.com" <Trond.Myklebust@...app.com>
CC:	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
	Pavel Emelianov <xemul@...allels.com>,
	"neilb@...e.de" <neilb@...e.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	James Bottomley <jbottomley@...allels.com>,
	"bfields@...ldses.org" <bfields@...ldses.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"devel@...nvz.org" <devel@...nvz.org>
Subject: Re: [PATCH] SUNRPC: skip dead but not buried clients on PipeFS events

Sorry, but ignore this patch too.
It can't be that simple because of these cl_count tricks in rpc_release_client...

19.04.2012 14:57, Stanislav Kinsbursky пишет:
> These clients can't be safely dereferenced if their counter in 0.
>
> Signee-off-by: Stanislav Kinsbursky<skinsbursky@...allels.com>
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@...allels.com>
>
> ---
>   net/sunrpc/clnt.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index 6797246..591994d 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -218,7 +218,8 @@ static struct rpc_clnt *rpc_get_client_for_event(struct net *net, int event)
>   		if (((event == RPC_PIPEFS_MOUNT)&&  clnt->cl_dentry) ||
>   		    ((event == RPC_PIPEFS_UMOUNT)&&  !clnt->cl_dentry))
>   			continue;
> -		atomic_inc(&clnt->cl_count);
> +		if (atomic_inc_return(&clnt->cl_count) == 1)
> +			continue;
>   		spin_unlock(&sn->rpc_client_lock);
>   		return clnt;
>   	}
>


-- 
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/