linux-kernel - Re: [PATCH v8 1/6] Extcon (external connector): import Android's switch class and modify.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120419113818.GA3046@opensource.wolfsonmicro.com>
Date:	Thu, 19 Apr 2012 12:38:19 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	LKML <linux-kernel@...r.kernel.org>, NeilBrown <neilb@...e.de>,
	Randy Dunlap <rdunlap@...otime.net>,
	Mike Lockwood <lockwood@...roid.com>,
	Arve Hjønnevag <arve@...roid.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Morten CHRISTIANSEN <morten.christiansen@...ricsson.com>,
	John Stultz <john.stultz@...aro.org>,
	Joerg Roedel <joerg.roedel@....com>, myungjoo.ham@...il.com,
	cw00.choi@...sung.com
Subject: Re: [PATCH v8 1/6] Extcon (external connector): import Android's
 switch class and modify.

On Thu, Apr 19, 2012 at 11:41:33AM +0900, MyungJoo Ham wrote:
> External connector class (extcon) is based on and an extension of
> Android kernel's switch class located at linux/drivers/switch/.

Reviewed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> +comment "Extcon Class Configuration"
> +
> +config EXTCON_ANDROID_COMPATIBLE
> +	bool "Class name uses 'switch' to be compatible with Android kernel"
> +	depends on ANDROID
> +	help
> +	  The class name of extcon device drivers are set 'switch' in order
> +	  to be compatible with Android kernel switch framework. With this
> +	  option enabled, Android userspace platform may use extcon device
> +	  drivers as if they are switch device drivers.

Though I think this is out of date now?  Not a big deal and could be
fixed up later.

> +#if defined(CONFIG_ANDROID) && !defined(CONFIG_ANDROID_SWITCH)
> +		switch_class = class_compat_register("switch");
> +		if (WARN(!switch_class, "cannot allocate"))
> +			return -ENOMEM;
> +#endif /* CONFIG_ANDROID && !defined(CONFIG_ANDROID_SWITCH) */

This does the above but differently.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)